]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mailbox: zynqmp: Remove invalid __percpu annotation in zynqmp_ipi_probe()
authorUros Bizjak <ubizjak@gmail.com>
Sat, 14 Dec 2024 09:12:59 +0000 (10:12 +0100)
committerJassi Brar <jassisinghbrar@gmail.com>
Sat, 18 Jan 2025 22:20:21 +0000 (16:20 -0600)
struct zynqmp_ipi_pdata __percpu *pdata is not a per-cpu variable,
so it should not be annotated with __percpu annotation.

Remove invalid __percpu annotation to fix several

zynqmp-ipi-mailbox.c:920:15: warning: incorrect type in assignment (different address spaces)
zynqmp-ipi-mailbox.c:920:15:    expected struct zynqmp_ipi_pdata [noderef] __percpu *pdata
zynqmp-ipi-mailbox.c:920:15:    got void *
zynqmp-ipi-mailbox.c:927:56: warning: incorrect type in argument 3 (different address spaces)
zynqmp-ipi-mailbox.c:927:56:    expected unsigned int [usertype] *out_value
zynqmp-ipi-mailbox.c:927:56:    got unsigned int [noderef] __percpu *
...

and several

drivers/mailbox/zynqmp-ipi-mailbox.c:924:9: warning: dereference of noderef expression
...

sparse warnings.

There were no changes in the resulting object file.

Cc: stable@vger.kernel.org
Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Tanmay Shah <tanmay.shah@amd.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/zynqmp-ipi-mailbox.c

index aa5249da59b2f566e53ae9f9e533ab29848ac388..0c143beaafda6092288b75d2cf9ced4d424ebf4c 100644 (file)
@@ -905,7 +905,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct device_node *nc, *np = pdev->dev.of_node;
-       struct zynqmp_ipi_pdata __percpu *pdata;
+       struct zynqmp_ipi_pdata *pdata;
        struct of_phandle_args out_irq;
        struct zynqmp_ipi_mbox *mbox;
        int num_mboxes, ret = -EINVAL;