]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/vkms: Fix cpu_to_le16()/le16_to_cpu() warnings
authorJosé Expósito <jose.exposito89@gmail.com>
Tue, 16 Jul 2024 16:17:26 +0000 (18:17 +0200)
committerJosé Expósito <jose.exposito89@gmail.com>
Thu, 8 Aug 2024 08:04:13 +0000 (10:04 +0200)
Building with Sparse enabled prints this warning for cpu_to_le16()
calls:

    warning: incorrect type in assignment (different base types)
        expected unsigned short [usertype]
        got restricted __le16 [usertype]

And this warning for le16_to_cpu() calls:

    warning: cast to restricted __le16

Declare the target buffer as __le16 to fix both warnings.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Acked-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240716161725.41408-2-jose.exposito89@gmail.com
drivers/gpu/drm/vkms/vkms_formats.c

index 36046b12f29686ecb30831ec3709fa8b8996b2c9..040b7f113a3b4382a3853505a7d886908c2a94ae 100644 (file)
@@ -75,7 +75,7 @@ static void XRGB8888_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_pixe
 
 static void ARGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_pixel)
 {
-       u16 *pixels = (u16 *)src_pixels;
+       __le16 *pixels = (__force __le16 *)src_pixels;
 
        out_pixel->a = le16_to_cpu(pixels[3]);
        out_pixel->r = le16_to_cpu(pixels[2]);
@@ -85,7 +85,7 @@ static void ARGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_
 
 static void XRGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_pixel)
 {
-       u16 *pixels = (u16 *)src_pixels;
+       __le16 *pixels = (__force __le16 *)src_pixels;
 
        out_pixel->a = (u16)0xffff;
        out_pixel->r = le16_to_cpu(pixels[2]);
@@ -95,7 +95,7 @@ static void XRGB16161616_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_
 
 static void RGB565_to_argb_u16(u8 *src_pixels, struct pixel_argb_u16 *out_pixel)
 {
-       u16 *pixels = (u16 *)src_pixels;
+       __le16 *pixels = (__force __le16 *)src_pixels;
 
        s64 fp_rb_ratio = drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(31));
        s64 fp_g_ratio = drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(63));
@@ -178,7 +178,7 @@ static void argb_u16_to_XRGB8888(u8 *dst_pixels, struct pixel_argb_u16 *in_pixel
 
 static void argb_u16_to_ARGB16161616(u8 *dst_pixels, struct pixel_argb_u16 *in_pixel)
 {
-       u16 *pixels = (u16 *)dst_pixels;
+       __le16 *pixels = (__force __le16 *)dst_pixels;
 
        pixels[3] = cpu_to_le16(in_pixel->a);
        pixels[2] = cpu_to_le16(in_pixel->r);
@@ -188,9 +188,9 @@ static void argb_u16_to_ARGB16161616(u8 *dst_pixels, struct pixel_argb_u16 *in_p
 
 static void argb_u16_to_XRGB16161616(u8 *dst_pixels, struct pixel_argb_u16 *in_pixel)
 {
-       u16 *pixels = (u16 *)dst_pixels;
+       __le16 *pixels = (__force __le16 *)dst_pixels;
 
-       pixels[3] = 0xffff;
+       pixels[3] = cpu_to_le16(0xffff);
        pixels[2] = cpu_to_le16(in_pixel->r);
        pixels[1] = cpu_to_le16(in_pixel->g);
        pixels[0] = cpu_to_le16(in_pixel->b);
@@ -198,7 +198,7 @@ static void argb_u16_to_XRGB16161616(u8 *dst_pixels, struct pixel_argb_u16 *in_p
 
 static void argb_u16_to_RGB565(u8 *dst_pixels, struct pixel_argb_u16 *in_pixel)
 {
-       u16 *pixels = (u16 *)dst_pixels;
+       __le16 *pixels = (__force __le16 *)dst_pixels;
 
        s64 fp_rb_ratio = drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(31));
        s64 fp_g_ratio = drm_fixp_div(drm_int2fixp(65535), drm_int2fixp(63));