]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: lantiq_gswip: ignore SerDes modes in phylink_mac_config()
authorDaniel Golle <daniel@makrotopia.org>
Sat, 30 Aug 2025 02:33:48 +0000 (03:33 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 3 Sep 2025 00:45:42 +0000 (17:45 -0700)
We can safely ignore SerDes interface modes 1000Base-X, 2500Base-X and
SGMII in phylink_mac_config() as they are being taken care of by the PCS
and the SGMII port anyway doesn't have MII_CFG and MII_PCDU registers
and hence gswip_phylink_mac_config() is already a no-op apart from
outputing a misleading error message.

Return early in case of SerDes interface modes to avoid printing that
error message.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Hauke Mehrtens <hauke@hauke-m.de>
Link: https://patch.msgid.link/dcb066d6a02e6340314b5ff4f73937757a4f8eb3.1756520811.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq/lantiq_gswip.c

index acb6996356e9efe21f96f6bd44ff2cfcc18b1377..3e2a54569828e560fdcbd7623e3028fa4ce2b19b 100644 (file)
@@ -1444,6 +1444,10 @@ static void gswip_phylink_mac_config(struct phylink_config *config,
        miicfg |= GSWIP_MII_CFG_LDCLKDIS;
 
        switch (state->interface) {
+       case PHY_INTERFACE_MODE_SGMII:
+       case PHY_INTERFACE_MODE_1000BASEX:
+       case PHY_INTERFACE_MODE_2500BASEX:
+               return;
        case PHY_INTERFACE_MODE_MII:
        case PHY_INTERFACE_MODE_INTERNAL:
                miicfg |= GSWIP_MII_CFG_MODE_MIIM;