pg_upgrade: no need to remove "members" files for pre-9.3 upgrades

Per analysis by Alvaro

Backpatch through 9.3

diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
index 91618f8b5388eaccd0c88cda3514115b1169ee76..7e73f7e1ae49ebd896aaf5a1b880871124bc5ba7 100644 (file)
--- a/contrib/pg_upgrade/pg_upgrade.c
+++ b/contrib/pg_upgrade/pg_upgrade.c
@@ -452,11 +452,11 @@ copy_clog_xlog_xid(void)
        else if (new_cluster.controldata.cat_ver >= MULTIXACT_FORMATCHANGE_CAT_VER)
        {
                /*
-                * Remove files created by initdb that no longer match the
-                * new multi-xid value.
+                * Remove offsets/0000 file created by initdb that no longer matches
+                * the new multi-xid value.  "members" starts at zero so no need to
+                * remove it.
                 */
                remove_new_subdir("pg_multixact/offsets", false);
-               remove_new_subdir("pg_multixact/members", false);
 
                prep_status("Setting oldest multixact ID on new cluster");