]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c++: Implement C++26 P2893R3 - Variadic friends [PR114459]
authorJakub Jelinek <jakub@redhat.com>
Tue, 7 May 2024 20:38:01 +0000 (22:38 +0200)
committerJakub Jelinek <jakub@redhat.com>
Tue, 7 May 2024 20:38:01 +0000 (22:38 +0200)
The following patch imeplements the C++26 P2893R3 - Variadic friends
paper.  The paper allows for the friend type declarations to specify
more than one friend type specifier and allows to specify ... at
the end of each.  The patch doesn't introduce tentative parsing of
friend-type-declaration non-terminal, but rather just extends existing
parsing where it is a friend declaration which ends with ; after the
declaration specifiers to the cases where it ends with ...; or , or ...,
In that case it pedwarns for cxx_dialect < cxx26, handles the ... and
if there is , continues in a loop to parse the further friend type
specifiers.

2024-05-07  Jakub Jelinek  <jakub@redhat.com>

PR c++/114459
gcc/c-family/
* c-cppbuiltin.cc (c_cpp_builtins): Predefine
__cpp_variadic_friend=202403L for C++26.
gcc/cp/
* parser.cc (cp_parser_member_declaration): Implement C++26
P2893R3 - Variadic friends.  Parse friend type declarations
with ... or with more than one friend type specifier.
* friend.cc (make_friend_class): Allow TYPE_PACK_EXPANSION.
* pt.cc (instantiate_class_template): Handle PACK_EXPANSION_P
in friend classes.
gcc/testsuite/
* g++.dg/cpp26/feat-cxx26.C (__cpp_variadic_friend): Add test.
* g++.dg/cpp26/variadic-friend1.C: New test.

gcc/c-family/c-cppbuiltin.cc
gcc/cp/friend.cc
gcc/cp/parser.cc
gcc/cp/pt.cc
gcc/testsuite/g++.dg/cpp26/feat-cxx26.C
gcc/testsuite/g++.dg/cpp26/variadic-friend1.C [new file with mode: 0644]

index b6f25e4db3c06a1addc09a47335fe5184cb4a100..d9b84a0f1b97fa1f50c5b91502b0a31f6ba1e1f6 100644 (file)
@@ -1093,6 +1093,7 @@ c_cpp_builtins (cpp_reader *pfile)
          cpp_define (pfile, "__cpp_placeholder_variables=202306L");
          cpp_define (pfile, "__cpp_structured_bindings=202403L");
          cpp_define (pfile, "__cpp_deleted_function=202403L");
+         cpp_define (pfile, "__cpp_variadic_friend=202403L");
        }
       if (flag_concepts)
         {
index 758ea87b1721ed6af72312dda637df9613108253..2e70d0160c46f4e497dedb56e19c6b8f85038984 100644 (file)
@@ -279,7 +279,8 @@ make_friend_class (tree type, tree friend_type, bool complain)
     }
 
   if (! MAYBE_CLASS_TYPE_P (friend_type)
-      && TREE_CODE (friend_type) != TEMPLATE_TEMPLATE_PARM)
+      && TREE_CODE (friend_type) != TEMPLATE_TEMPLATE_PARM
+      && TREE_CODE (friend_type) != TYPE_PACK_EXPANSION)
     {
       /* N1791: If the type specifier in a friend declaration designates a
         (possibly cv-qualified) class type, that class is declared as a
index 775067ed4bc5836bc60ccfd07bed3900c6af602c..c4191200291d0c798f80fd4b4e060825d7b021a4 100644 (file)
@@ -28100,8 +28100,17 @@ cp_parser_member_declaration (cp_parser* parser)
       && cp_parser_parse_and_diagnose_invalid_type_name (parser))
     goto out;
   /* If there is no declarator, then the decl-specifier-seq should
-     specify a type.  */
-  if (cp_lexer_next_token_is (parser->lexer, CPP_SEMICOLON))
+     specify a type.  For C++26 Variadic friends don't just check for
+     a semicolon, but also for a comma and in both cases optionally
+     preceded by ellipsis.  */
+  if (cp_lexer_next_token_is (parser->lexer, CPP_SEMICOLON)
+      || (cp_parser_friend_p (&decl_specifiers)
+         && cxx_dialect >= cxx11
+         && (cp_lexer_next_token_is (parser->lexer, CPP_COMMA)
+             || (cp_lexer_next_token_is (parser->lexer, CPP_ELLIPSIS)
+                 && (cp_lexer_nth_token_is (parser->lexer, 2, CPP_SEMICOLON)
+                     || cp_lexer_nth_token_is (parser->lexer, 2,
+                                               CPP_COMMA))))))
     {
       /* If there was no decl-specifier-seq, and the next token is a
         `;', then we have something like:
@@ -28136,44 +28145,81 @@ cp_parser_member_declaration (cp_parser* parser)
            {
              /* If the `friend' keyword was present, the friend must
                 be introduced with a class-key.  */
-              if (!declares_class_or_enum && cxx_dialect < cxx11)
-                pedwarn (decl_spec_token_start->location, OPT_Wpedantic,
-                         "in C++03 a class-key must be used "
-                         "when declaring a friend");
-              /* In this case:
-
-                   template <typename T> struct A {
-                     friend struct A<T>::B;
-                   };
-
-                 A<T>::B will be represented by a TYPENAME_TYPE, and
-                 therefore not recognized by check_tag_decl.  */
-              if (!type)
-                {
-                  type = decl_specifiers.type;
-                  if (type && TREE_CODE (type) == TYPE_DECL)
-                    type = TREE_TYPE (type);
-                }
-              /* Warn if an attribute cannot appear here, as per
-                 [dcl.attr.grammar]/5.  But not when declares_class_or_enum:
-                 we ignore attributes in elaborated-type-specifiers.  */
-              if (!declares_class_or_enum
-                  && cxx11_attribute_p (decl_specifiers.attributes))
-                {
-                  decl_specifiers.attributes = NULL_TREE;
-                  if (warning_at (decl_spec_token_start->location,
-                                  OPT_Wattributes, "attribute ignored"))
-                    inform (decl_spec_token_start->location, "an attribute "
-                            "that appertains to a friend declaration that "
-                            "is not a definition is ignored");
-                }
-              if (!type || !TYPE_P (type))
-                error_at (decl_spec_token_start->location,
-                          "friend declaration does not name a class or "
-                          "function");
-              else
-                make_friend_class (current_class_type, type,
-                                   /*complain=*/true);
+             if (!declares_class_or_enum && cxx_dialect < cxx11)
+               pedwarn (decl_spec_token_start->location, OPT_Wpedantic,
+                        "in C++03 a class-key must be used "
+                        "when declaring a friend");
+             if (!cp_lexer_next_token_is (parser->lexer, CPP_SEMICOLON)
+                 && cxx_dialect < cxx26)
+               pedwarn (cp_lexer_peek_token (parser->lexer)->location,
+                        OPT_Wc__26_extensions,
+                        "variadic friends or friend type declarations with "
+                        "multiple types only available with "
+                        "%<-std=c++2c%> or %<-std=gnu++2c%>");
+             location_t friend_loc = decl_specifiers.locations[ds_friend];
+             do
+               {
+                 /* In this case:
+
+                    template <typename T> struct A {
+                      friend struct A<T>::B;
+                    };
+
+                    A<T>::B will be represented by a TYPENAME_TYPE, and
+                    therefore not recognized by check_tag_decl.  */
+                 if (!type)
+                   {
+                     type = decl_specifiers.type;
+                     if (type && TREE_CODE (type) == TYPE_DECL)
+                       type = TREE_TYPE (type);
+                   }
+                 /* Warn if an attribute cannot appear here, as per
+                    [dcl.attr.grammar]/5.  But not when
+                    declares_class_or_enum: we ignore attributes in
+                    elaborated-type-specifiers.  */
+                 if (!declares_class_or_enum
+                     && cxx11_attribute_p (decl_specifiers.attributes))
+                   {
+                     decl_specifiers.attributes = NULL_TREE;
+                     if (warning_at (decl_spec_token_start->location,
+                                     OPT_Wattributes, "attribute ignored"))
+                       inform (decl_spec_token_start->location, "an attribute "
+                               "that appertains to a friend declaration that "
+                               "is not a definition is ignored");
+                   }
+                 bool ellipsis = cp_lexer_next_token_is (parser->lexer,
+                                                         CPP_ELLIPSIS);
+                 if (ellipsis)
+                   cp_lexer_consume_token (parser->lexer);
+                 if (!type || !TYPE_P (type))
+                   error_at (decl_spec_token_start->location,
+                             "friend declaration does not name a class or "
+                             "function");
+                 else
+                   {
+                     if (ellipsis)
+                       type = make_pack_expansion (type);
+                     if (type != error_mark_node)
+                       make_friend_class (current_class_type, type,
+                                          /*complain=*/true);
+                   }
+                 if (!cp_lexer_next_token_is (parser->lexer, CPP_COMMA))
+                   break;
+                 cp_lexer_consume_token (parser->lexer);
+                 clear_decl_specs (&decl_specifiers);
+                 decl_specifiers.locations[ds_friend] = friend_loc;
+                 decl_specifiers.any_specifiers_p = true;
+                 declares_class_or_enum = false;
+                 cp_parser_type_specifier (parser,
+                                           CP_PARSER_FLAGS_TYPENAME_OPTIONAL,
+                                           &decl_specifiers,
+                                           /*is_declaration=*/true,
+                                           &declares_class_or_enum, NULL);
+                 type = check_tag_decl (&decl_specifiers,
+                                        /*explicit_type_instantiation_p=*/
+                                        false);
+               }
+             while (1);
            }
          /* If there is no TYPE, an error message will already have
             been issued.  */
index 7a3a4e7d77e4f06673d6745692700480cc5e6918..1816bfd1f4012e42b40af204503ed34f370e0ab3 100644 (file)
@@ -12693,6 +12693,22 @@ instantiate_class_template (tree type)
                                        tf_warning_or_error, NULL_TREE);
                  --processing_template_decl;
                }
+             else if (PACK_EXPANSION_P (friend_type))
+               {
+                 friend_type = tsubst_pack_expansion (friend_type, args,
+                                                      tf_warning_or_error,
+                                                      NULL_TREE);
+                 if (friend_type != error_mark_node)
+                   {
+                     unsigned int len = TREE_VEC_LENGTH (friend_type);
+                     for (unsigned int idx = 0; idx < len; ++idx)
+                       if (TREE_VEC_ELT (friend_type, idx) != error_mark_node)
+                         make_friend_class (type,
+                                            TREE_VEC_ELT (friend_type, idx),
+                                            /*complain=*/false);
+                   }
+                 friend_type = error_mark_node;
+               }
              else if (uses_template_parms (friend_type))
                /* friend class C<T>;  */
                friend_type = tsubst (friend_type, args,
index de66dcccd026a6498c0b069116817d57d5c0e9d9..8a5fd64d39604b03af738ad9d5f3b826c04cdf51 100644 (file)
 #elif __cpp_deleted_function != 202403
 #  error "__cpp_deleted_function != 202403"
 #endif
+
+#ifndef __cpp_variadic_friend
+#  error "__cpp_variadic_friend"
+#elif __cpp_variadic_friend != 202403
+#  error "__cpp_variadic_friend != 202403"
+#endif
diff --git a/gcc/testsuite/g++.dg/cpp26/variadic-friend1.C b/gcc/testsuite/g++.dg/cpp26/variadic-friend1.C
new file mode 100644 (file)
index 0000000..25c6c45
--- /dev/null
@@ -0,0 +1,58 @@
+// P2893R3 - Variadic friends
+// { dg-do compile { target c++11 } }
+// { dg-options "" }
+
+template <class... Ts>
+class A {
+  class X {};
+  friend Ts...;                // { dg-warning "variadic friends or friend type declarations with multiple types only available with" "" { target c++23_down } }
+};
+template <class... Ts, class... Us>
+class A<A<Ts...>, A<Us...>> {
+  class X {};
+  friend
+#if __cplusplus < 202002L
+  typename
+#endif
+  Ts::Y..., Us...;     // { dg-warning "variadic friends or friend type declarations with multiple types only available with" "" { target c++23_down } }
+};
+template <typename T, typename U>
+class B {
+  class X {};
+  friend T, U;         // { dg-warning "variadic friends or friend type declarations with multiple types only available with" "" { target c++23_down } }
+};
+template <typename T, typename U, typename... Vs>
+class C {
+  class X {};
+  friend U, Vs..., T;  // { dg-warning "variadic friends or friend type declarations with multiple types only available with" "" { target c++23_down } }
+};
+class E;
+class F;
+class G;
+class H;
+class I;
+class J;
+class K;
+class L;
+class M;
+class N;
+class O;
+class P;
+class E : A<E, F>::X {};
+class F : A<E, F>::X {};
+class G : B<G, H>::X {};
+class H : B<G, H>::X {};
+class I : C<I, J>::X {};
+class J : C<I, J>::X {};
+class K : C<K, L, M, N, O>::X {};
+class L : C<K, L, M, N, O>::X {};
+class M : C<K, L, M, N, O>::X {};
+class N : C<K, L, M, N, O>::X {};
+class O : C<K, L, M, N, O>::X {};
+struct Q { class Y : A<A<Q>, A<P, long>>::X {}; };
+class P : A<A<Q>, A<P, long>>::X {};
+struct R { class Y; };
+struct S { class Y; };
+class R::Y : A<A<R, S>, A<P, double>>::X {};
+class S::Y : A<A<R, S>, A<P, double>>::X {};
+A<int> a;