]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: hisilicon: hip04: fix OF node leak in probe()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 27 Aug 2024 14:44:19 +0000 (16:44 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Aug 2024 00:55:23 +0000 (17:55 -0700)
Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240827144421.52852-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hip04_eth.c

index b91e7a06b97f7de90c1f1cebe6e515493a74b836..beb815e5289b129db0dac78cfa8b9dc609c425bd 100644 (file)
@@ -947,6 +947,7 @@ static int hip04_mac_probe(struct platform_device *pdev)
        priv->tx_coalesce_timer.function = tx_done;
 
        priv->map = syscon_node_to_regmap(arg.np);
+       of_node_put(arg.np);
        if (IS_ERR(priv->map)) {
                dev_warn(d, "no syscon hisilicon,hip04-ppe\n");
                ret = PTR_ERR(priv->map);