]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: qcom-rpmh: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 14 Aug 2024 15:04:09 +0000 (17:04 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 14 Aug 2024 17:21:46 +0000 (18:21 +0100)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20240814-cleanup-h-of-node-put-regulator-v1-5-87151088b883@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom-rpmh-regulator.c

index 80e304711345bb852b399e1a879181cfc9685088..6b4cb7ba49c7db93211605ddb818753cf7185136 100644 (file)
@@ -1537,7 +1537,6 @@ static int rpmh_regulator_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        const struct rpmh_vreg_init_data *vreg_data;
-       struct device_node *node;
        struct rpmh_vreg *vreg;
        const char *pmic_id;
        int ret;
@@ -1552,19 +1551,15 @@ static int rpmh_regulator_probe(struct platform_device *pdev)
                return ret;
        }
 
-       for_each_available_child_of_node(dev->of_node, node) {
+       for_each_available_child_of_node_scoped(dev->of_node, node) {
                vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL);
-               if (!vreg) {
-                       of_node_put(node);
+               if (!vreg)
                        return -ENOMEM;
-               }
 
                ret = rpmh_regulator_init_vreg(vreg, dev, node, pmic_id,
                                                vreg_data);
-               if (ret < 0) {
-                       of_node_put(node);
+               if (ret < 0)
                        return ret;
-               }
        }
 
        return 0;