]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Bluetooth: hci_core: Don't use hci_prepare_cmd
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Mon, 1 Jul 2024 20:13:56 +0000 (16:13 -0400)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Mon, 15 Jul 2024 14:11:29 +0000 (10:11 -0400)
This replaces the instance of hci_prepare_cmd with hci_cmd_sync_alloc
since the former is part of hci_request.c which is considered
deprecated.

Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
include/net/bluetooth/hci_sync.h
net/bluetooth/hci_core.c
net/bluetooth/hci_sync.c

index 620e6014beb229054bceb686bde2f4cd2f2e6ea2..a8d88247ac89a9705a6a8cce543c4864f066f4cb 100644 (file)
@@ -20,6 +20,10 @@ struct hci_cmd_sync_work_entry {
 };
 
 struct adv_info;
+
+struct sk_buff *hci_cmd_sync_alloc(struct hci_dev *hdev, u16 opcode, u32 plen,
+                                  const void *param, struct sock *sk);
+
 /* Function with sync suffix shall not be called with hdev->lock held as they
  * wait the command to complete and in the meantime an event could be received
  * which could attempt to acquire hdev->lock causing a deadlock.
index cce755a84ea782312a33aebd8c29c7ce004e656b..9bdd3e1f8cfc64fb24b4f2f17be3a46d2c0e3730 100644 (file)
@@ -3054,7 +3054,7 @@ int hci_send_cmd(struct hci_dev *hdev, __u16 opcode, __u32 plen,
 
        BT_DBG("%s opcode 0x%4.4x plen %d", hdev->name, opcode, plen);
 
-       skb = hci_prepare_cmd(hdev, opcode, plen, param);
+       skb = hci_cmd_sync_alloc(hdev, opcode, plen, param, NULL);
        if (!skb) {
                bt_dev_err(hdev, "no memory for command");
                return -ENOMEM;
@@ -3089,7 +3089,7 @@ int __hci_cmd_send(struct hci_dev *hdev, u16 opcode, u32 plen,
                return -EINVAL;
        }
 
-       skb = hci_prepare_cmd(hdev, opcode, plen, param);
+       skb = hci_cmd_sync_alloc(hdev, opcode, plen, param, NULL);
        if (!skb) {
                bt_dev_err(hdev, "no memory for command (opcode 0x%4.4x)",
                           opcode);
index 46b394842a27e6e86ed59a86a95480da72f4ebe3..0c8888448d3c6f442c32dfde0e0d9545153eeaf3 100644 (file)
@@ -49,9 +49,8 @@ static void hci_cmd_sync_complete(struct hci_dev *hdev, u8 result, u16 opcode,
        wake_up_interruptible(&hdev->req_wait_q);
 }
 
-static struct sk_buff *hci_cmd_sync_alloc(struct hci_dev *hdev, u16 opcode,
-                                         u32 plen, const void *param,
-                                         struct sock *sk)
+struct sk_buff *hci_cmd_sync_alloc(struct hci_dev *hdev, u16 opcode, u32 plen,
+                                  const void *param, struct sock *sk)
 {
        int len = HCI_COMMAND_HDR_SIZE + plen;
        struct hci_command_hdr *hdr;