]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: mux-spop: use explicit __objt_server on idle conn reinsert
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 6 Dec 2024 16:46:35 +0000 (17:46 +0100)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Fri, 6 Dec 2024 17:02:55 +0000 (18:02 +0100)
This commit is the counterpart of the previous one for SPOP mux. It
replaces objt_server() by unsafe __objt_server(), as conn target is
guarantee to point to a valid server instance, which can then be used as
_srv_add_idle() argument.

This should fix coverity report from github issue #2811.

src/mux_spop.c

index 576688953282bde70eaaca7f209d8a1b45c2794d..96d62d0f810a55d3d4dc07f07de1a3128c76630a 100644 (file)
@@ -2492,7 +2492,7 @@ static struct task *spop_io_cb(struct task *t, void *ctx, unsigned int state)
                t = NULL;
 
        if (!ret && conn_in_list) {
-               struct server *srv = objt_server(conn->target);
+               struct server *srv = __objt_server(conn->target);
 
                HA_SPIN_LOCK(IDLE_CONNS_LOCK, &idle_conns[tid].idle_conns_lock);
                _srv_add_idle(srv, conn, conn_in_list == CO_FL_SAFE_LIST);