submodule--helper: fix a leak with repo_clear()

Call repo_clear() in ensure_core_worktree() to free the "struct
repository". Fixes a leak that's been here since
74d4731da1f (submodule--helper: replace connect-gitdir-workingtree by
ensure-core-worktree, 2018-08-13).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 3453faabd39fb6596f3cccf34e722e25dd6ac2b5..79ffcb50909846c470261842b4abc632b5e870e4 100644 (file)
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -2397,6 +2397,7 @@ static int ensure_core_worktree(const char *path)
                strbuf_release(&sb);
        }
 
+       repo_clear(&subrepo);
        return 0;
 }