]> git.ipfire.org Git - thirdparty/git.git/commitdiff
GitHub workflow: automatically follow minor updates of setup-msbuild
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 7 Oct 2020 08:17:49 +0000 (08:17 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 7 Oct 2020 16:54:53 +0000 (09:54 -0700)
It is the custom to follow minor updates of GitHub Actions
automatically, by using the suffix `@v1`. Actions' maintainers will then
update that `v1` ref to point to the newest.

However, for `microsoft/setup-msbuild`, 889cacb6897 (ci: configure
GitHub Actions for CI/PR, 2020-04-11) uses a very specific `@v1.0.0`
suffix.

In this instance, that is a problem: should `setup-msbuild` release a
new version that intends to fix a critical bug, we won't know it, and we
won't use it.

Such a scenario is not theoretical. It is happening right now:
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands

Let's simplify our setup, allowing us to benefit from automatically
using the newest v1.x.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
.github/workflows/main.yml

index fcfd138ff1833bcad3c34113f6de10809739e5d2..14ff94dcbe346d762924e1bfae556bc5c07bd863 100644 (file)
@@ -154,7 +154,7 @@ jobs:
         Expand-Archive compat.zip -DestinationPath . -Force
         Remove-Item compat.zip
     - name: add msbuild to PATH
-      uses: microsoft/setup-msbuild@v1.0.0
+      uses: microsoft/setup-msbuild@v1
     - name: copy dlls to root
       shell: powershell
       run: |