]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ov9650: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:32 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:27 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov9650.c

index 026ea34d62914c576203ac697c5dbac8e3f09527..c94e8fe29f226cc0bb799b425fe45c194cd25062 100644 (file)
@@ -1494,9 +1494,10 @@ static int ov965x_probe(struct i2c_client *client)
        }
 
        if (dev_fwnode(&client->dev)) {
-               ov965x->clk = devm_clk_get(&client->dev, NULL);
+               ov965x->clk = devm_v4l2_sensor_clk_get(&client->dev, NULL);
                if (IS_ERR(ov965x->clk))
-                       return PTR_ERR(ov965x->clk);
+                       return dev_err_probe(&client->dev, PTR_ERR(ov965x->clk),
+                                            "failed to get the clock\n");
                ov965x->mclk_frequency = clk_get_rate(ov965x->clk);
 
                ret = ov965x_configure_gpios(ov965x);