]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: ep93xx: Fix wrong irq numbers in port F
authorNikita Shubin <nikita.shubin@maquefel.me>
Tue, 9 Feb 2021 13:31:06 +0000 (16:31 +0300)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 15 Feb 2021 10:43:33 +0000 (11:43 +0100)
Port F IRQ's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE.

So we need to specify girq->first otherwise:

"If device tree is used, then first_irq will be 0 and
IRQ's get mapped dynamically on the fly"

And that's not the thing we want.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-ep93xx.c

index 94d9fa0d6aa70d1d6b94d30b34bec6cdea9b3f16..3dea4ce929ab203efab4cd785af92d8c360e5474 100644 (file)
@@ -416,6 +416,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
                girq->default_type = IRQ_TYPE_NONE;
                girq->handler = handle_level_irq;
                gc->to_irq = ep93xx_gpio_f_to_irq;
+               girq->first = EP93XX_GPIO_F_IRQ_BASE;
        }
 
        return devm_gpiochip_add_data(dev, gc, epg);