]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wcn36xx: consider CTRL_EOP bit when looking for valid descriptors
authorDaniel Mack <daniel@zonque.org>
Wed, 23 May 2018 08:14:44 +0000 (11:14 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 25 May 2018 10:07:43 +0000 (13:07 +0300)
In reap_tx_dxes(), when we iterate over the linked descriptors, only
consider such valid that have WCN36xx_DXE_CTRL_EOP set.

This is what the prima downstream driver is doing as well.

Signed-off-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/wcn36xx/dxe.c

index 8c64e05ca3b765afe24889ee24b565f9bad0e8bd..06cfe8d311f39ba3bcdc8a0d7756d05693a5d367 100644 (file)
@@ -370,7 +370,9 @@ static void reap_tx_dxes(struct wcn36xx *wcn, struct wcn36xx_dxe_ch *ch)
        do {
                if (READ_ONCE(ctl->desc->ctrl) & WCN36xx_DXE_CTRL_VLD)
                        break;
-               if (ctl->skb) {
+
+               if (ctl->skb &&
+                   READ_ONCE(ctl->desc->ctrl) & WCN36xx_DXE_CTRL_EOP) {
                        dma_unmap_single(wcn->dev, ctl->desc->src_addr_l,
                                         ctl->skb->len, DMA_TO_DEVICE);
                        info = IEEE80211_SKB_CB(ctl->skb);