]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: bcmasp: Restore programming of TX map vector register
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Fri, 18 Jul 2025 21:22:42 +0000 (14:22 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 21 Jul 2025 23:41:36 +0000 (16:41 -0700)
On ASP versions v2.x we need to program the TX map vector register to
properly exercise end-to-end flow control, otherwise the TX engine can
either lock-up, or cause the hardware calculated checksum to be
wrong/corrupted when multiple back to back packets are being submitted
for transmission. This register defaults to 0, which means no flow
control being applied.

Fixes: e9f31435ee7d ("net: bcmasp: Add support for asp-v3.0")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250718212242.3447751-1-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c

index 0d61b8580d72b083a7c2297a58fe99d03e9dd8c9..f832562bd7a3e854c19fe637c2fd1f489c52a031 100644 (file)
@@ -818,6 +818,9 @@ static void bcmasp_init_tx(struct bcmasp_intf *intf)
        /* Tx SPB */
        tx_spb_ctrl_wl(intf, ((intf->channel + 8) << TX_SPB_CTRL_XF_BID_SHIFT),
                       TX_SPB_CTRL_XF_CTRL2);
+
+       if (intf->parent->tx_chan_offset)
+               tx_pause_ctrl_wl(intf, (1 << (intf->channel + 8)), TX_PAUSE_MAP_VECTOR);
        tx_spb_top_wl(intf, 0x1e, TX_SPB_TOP_BLKOUT);
 
        tx_spb_dma_wq(intf, intf->tx_spb_dma_addr, TX_SPB_DMA_READ);