]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
doc: Inform about aminsertcleanup optional NULLness
authorMichael Paquier <michael@paquier.xyz>
Tue, 22 Jul 2025 05:34:15 +0000 (14:34 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 22 Jul 2025 05:34:15 +0000 (14:34 +0900)
This index AM callback has been introduced in c1ec02be1d79 and it is
optional, currently only being used by BRIN.  Optional callbacks are
documented with NULL as possible value in amapi.h and indexam.sgml, but
this callback has missed this part of the description.

Reported-by: Peter Smith <smithpb2250@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHut+PvgYcPmPDi1YdHMJY5upnyGRpc0N8pk1xNB11xDSBwNog@mail.gmail.com
Backpatch-through: 17

doc/src/sgml/indexam.sgml
src/include/access/amapi.h

index 1aa4741a8eaeecf7a2a99df09761ea0aeaf6b34a..63d7e376f195e4d3a644c082df1703a43d68ccb1 100644 (file)
@@ -147,7 +147,7 @@ typedef struct IndexAmRoutine
     ambuild_function ambuild;
     ambuildempty_function ambuildempty;
     aminsert_function aminsert;
-    aminsertcleanup_function aminsertcleanup;
+    aminsertcleanup_function aminsertcleanup;   /* can be NULL */
     ambulkdelete_function ambulkdelete;
     amvacuumcleanup_function amvacuumcleanup;
     amcanreturn_function amcanreturn;   /* can be NULL */
index 52916bab7a31f3dfd0512d96566c72fc9acd39f6..70949de56ac700d17e2b414b54c1bca3cb935373 100644 (file)
@@ -293,7 +293,7 @@ typedef struct IndexAmRoutine
        ambuild_function ambuild;
        ambuildempty_function ambuildempty;
        aminsert_function aminsert;
-       aminsertcleanup_function aminsertcleanup;
+       aminsertcleanup_function aminsertcleanup;       /* can be NULL */
        ambulkdelete_function ambulkdelete;
        amvacuumcleanup_function amvacuumcleanup;
        amcanreturn_function amcanreturn;       /* can be NULL */