]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
smbd: remove call to fdos_mode() when setting DOS attrs
authorRalph Boehme <slow@samba.org>
Mon, 30 Oct 2023 18:04:56 +0000 (19:04 +0100)
committerJeremy Allison <jra@samba.org>
Sun, 5 Nov 2023 18:34:38 +0000 (18:34 +0000)
This added in 49a754b82d33fb523cda4151a865584ae52a2e2f to work with stored
itime based File-Ids. Since switching back to purely inode based File-Ids we
can remove this call that primed itime from DOS xattr.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/open.c

index 9e5bf2f67311b9e1d73717d72ac89066e62aa023..b99692f34edf2127f535a496058cc09cd0696dc8 100644 (file)
@@ -4414,7 +4414,6 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                /* Overwritten files should be initially set as archive */
                if ((info == FILE_WAS_OVERWRITTEN && lp_map_archive(SNUM(conn))) ||
                    lp_store_dos_attributes(SNUM(conn))) {
-                       (void)fdos_mode(fsp);
                        if (!posix_open) {
                                if (file_set_dosmode(conn, smb_fname,
                                            new_dos_attributes | FILE_ATTRIBUTE_ARCHIVE,