]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
misc: microchip: pci1xxxx: Resolve kernel panic during GPIO IRQ handling
authorRengarajan S <rengarajan.s@microchip.com>
Thu, 5 Dec 2024 13:36:25 +0000 (19:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jan 2025 14:47:35 +0000 (15:47 +0100)
Resolve kernel panic caused by improper handling of IRQs while
accessing GPIO values. This is done by replacing generic_handle_irq with
handle_nested_irq.

Fixes: 1f4d8ae231f4 ("misc: microchip: pci1xxxx: Add gpio irq handler and irq helper functions irq_ack, irq_mask, irq_unmask and irq_set_type of irq_chip.")
Cc: stable <stable@kernel.org>
Signed-off-by: Rengarajan S <rengarajan.s@microchip.com>
Link: https://lore.kernel.org/r/20241205133626.1483499-2-rengarajan.s@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c

index e616e3ec2b42fd3654e8995a603a30a9d3e3baac..558290bdb938cab4709b86ef49528f1f92f076ec 100644 (file)
@@ -277,7 +277,7 @@ static irqreturn_t pci1xxxx_gpio_irq_handler(int irq, void *dev_id)
                        writel(BIT(bit), priv->reg_base + INTR_STATUS_OFFSET(gpiobank));
                        spin_unlock_irqrestore(&priv->lock, flags);
                        irq = irq_find_mapping(gc->irq.domain, (bit + (gpiobank * 32)));
-                       generic_handle_irq(irq);
+                       handle_nested_irq(irq);
                }
        }
        spin_lock_irqsave(&priv->lock, flags);