]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: split out damos_test_commit_filter() core logic
authorSeongJae Park <sj@kernel.org>
Tue, 11 Nov 2025 18:44:01 +0000 (10:44 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 20 Nov 2025 21:43:59 +0000 (13:43 -0800)
damos_test_commit_filter() is written for only a single test case.  Split
out the core logic of damos_test_commit_filter() as a general one so that
it can be reused for multiple test cases.

Link: https://lkml.kernel.org/r/20251111184415.141757-3-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index ae97886137dc5e32ba84e8a3f02dd6a01f0e6a3e..31f90cfcabf3a3941a5a711db9660493108d7158 100644 (file)
@@ -497,6 +497,15 @@ static void damos_test_new_filter(struct kunit *test)
        damos_destroy_filter(filter);
 }
 
+static void damos_test_commit_filter_for(struct kunit *test,
+               struct damos_filter *dst, struct damos_filter *src)
+{
+       damos_commit_filter(dst, src);
+       KUNIT_EXPECT_EQ(test, dst->type, src->type);
+       KUNIT_EXPECT_EQ(test, dst->matching, src->matching);
+       KUNIT_EXPECT_EQ(test, dst->allow, src->allow);
+}
+
 static void damos_test_commit_filter(struct kunit *test)
 {
        struct damos_filter src_filter = {
@@ -509,10 +518,7 @@ static void damos_test_commit_filter(struct kunit *test)
                .allow = false,
        };
 
-       damos_commit_filter(&dst_filter, &src_filter);
-       KUNIT_EXPECT_EQ(test, dst_filter.type, src_filter.type);
-       KUNIT_EXPECT_EQ(test, dst_filter.matching, src_filter.matching);
-       KUNIT_EXPECT_EQ(test, dst_filter.allow, src_filter.allow);
+       damos_test_commit_filter_for(test, &dst_filter, &src_filter);
 }
 
 static void damos_test_filter_out(struct kunit *test)