]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mac80211: chanctx emulation set CHANGE_CHANNEL when in_reconfig
authorZong-Zhe Yang <kevin_yang@realtek.com>
Tue, 9 Jul 2024 07:35:31 +0000 (15:35 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 9 Jul 2024 09:29:09 +0000 (11:29 +0200)
Chanctx emulation didn't info IEEE80211_CONF_CHANGE_CHANNEL to drivers
during ieee80211_restart_hw (ieee80211_emulate_add_chanctx). It caused
non-chanctx drivers to not stand on the correct channel after recovery.
RX then behaved abnormally. Finally, disconnection/reconnection occurred.

So, set IEEE80211_CONF_CHANGE_CHANNEL when in_reconfig.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Link: https://patch.msgid.link/20240709073531.30565-1-kevin_yang@realtek.com
Cc: stable@vger.kernel.org
Fixes: 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx drivers")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/main.c

index 7578ea56c12f63c49465fcd82e0c425a50f457a7..85a267bdb3e3dd000482c620908888b08eede7d6 100644 (file)
@@ -148,7 +148,7 @@ static u32 ieee80211_calc_hw_conf_chan(struct ieee80211_local *local,
        offchannel_flag ^= local->hw.conf.flags & IEEE80211_CONF_OFFCHANNEL;
 
        /* force it also for scanning, since drivers might config differently */
-       if (offchannel_flag || local->scanning ||
+       if (offchannel_flag || local->scanning || local->in_reconfig ||
            !cfg80211_chandef_identical(&local->hw.conf.chandef, &chandef)) {
                local->hw.conf.chandef = chandef;
                changed |= IEEE80211_CONF_CHANGE_CHANNEL;