lib: Optimization - p_strconcat() doesn't need to allocate from data stack

Various other parts of the code already rely on p_malloc() not overwriting
t_buffer_get()'ed data. p_strconcat() can do that as well.

diff --git a/src/lib/strfuncs.c b/src/lib/strfuncs.c
index 266be153c49183970d8a02054375575241bfd2f2..0fa45beeb27cffd0495dccfc33239520d35560df 100644 (file)
--- a/src/lib/strfuncs.c
+++ b/src/lib/strfuncs.c
@@ -217,12 +217,9 @@ char *p_strconcat(pool_t pool, const char *str1, ...)
                ret = vstrconcat(str1, args, &len);
                t_buffer_alloc(len);
        } else {
-               T_BEGIN {
-                       temp = vstrconcat(str1, args, &len);
-                       t_buffer_alloc(len);
-                       ret = p_malloc(pool, len);
-                       memcpy(ret, temp, len);
-               } T_END;
+               temp = vstrconcat(str1, args, &len);
+               ret = p_malloc(pool, len);
+               memcpy(ret, temp, len);
        }
 
        va_end(args);