]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-auth: Fix memory leak in auth_client_request_abort()
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Mon, 18 Dec 2017 14:50:51 +0000 (16:50 +0200)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Thu, 25 Jan 2018 09:02:56 +0000 (11:02 +0200)
This caused memory leaks when authentication was aborted. For example
with IMAP:

a AUTHENTICATE PLAIN
*

Broken by 9137c55411aa39d41c1e705ddc34d5bd26c65021

src/lib-auth/auth-client-request.c

index 480fb42b304065588a4e472c926adbb074db7892..046f7c307dbf8aa060c2532e948234d3113dce43 100644 (file)
@@ -186,6 +186,7 @@ void auth_client_request_abort(struct auth_client_request **_request)
 
        auth_client_send_cancel(request->conn->client, request->id);
        call_callback(request, AUTH_REQUEST_STATUS_ABORT, NULL, NULL);
+       pool_unref(&request->pool);
 }
 
 unsigned int auth_client_request_get_id(struct auth_client_request *request)