]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ethernet: ti: am65-cpsw: set fwnode for ports
authorMichael Walle <mwalle@kernel.org>
Mon, 14 Apr 2025 08:43:35 +0000 (10:43 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 00:51:33 +0000 (17:51 -0700)
fwnode needs to be set for a device for fw_devlink to be able to
track/enforce its dependencies correctly. Without this, you'll see error
messages like this when the supplier has probed and tries to make sure
all its fwnode consumers are linked to it using device links:

am65-cpsw-nuss 8000000.ethernet: Failed to create device link (0x180) with supplier ..

Reviewed-by: Saravana Kannan <saravanak@google.com>
Signed-off-by: Michael Walle <mwalle@kernel.org>
Link: https://patch.msgid.link/20250414084336.4017237-2-mwalle@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index e78de79a5d78c2e673809841e5c6d2dc35c754a1..0a38776339769357d9c9c03a3a4737a9a1f469c9 100644 (file)
@@ -2749,7 +2749,7 @@ am65_cpsw_nuss_init_port_ndev(struct am65_cpsw_common *common, u32 port_idx)
        mutex_init(&ndev_priv->mm_lock);
        port->qos.link_speed = SPEED_UNKNOWN;
        SET_NETDEV_DEV(port->ndev, dev);
-       port->ndev->dev.of_node = port->slave.port_np;
+       device_set_node(&port->ndev->dev, of_fwnode_handle(port->slave.port_np));
 
        eth_hw_addr_set(port->ndev, port->slave.mac_addr);