]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/ttm: Fix compile error when CONFIG_SHMEM is not set
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 4 Jun 2025 12:51:21 +0000 (08:51 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 4 Jun 2025 15:49:03 +0000 (08:49 -0700)
When CONFIG_SHMEM is not set, the following compiler error occurs:

  ld: vmlinux.o: in function `ttm_backup_backup_page':
  (.text+0x10363bc): undefined reference to `shmem_writeout'
  make[3]: *** [/work/build/trace/nobackup/linux.git/scripts/Makefile.vmlinux:91: vmlinux.unstripped] Error 1

This is due to the replacement of writepage and calling swap_writeout()
and shmem_writeout() directly.  The issue is that when CONFIG_SHMEM is
not defined, shmem_writeout() is also not defined.

The function ttm_backup_backup_page() called mapping->a_ops->writepage()
which was then changed to call shmem_writeout() directly.

Even before commit 84798514db50 ("mm: Remove swap_writepage() and
shmem_writepage()"), it didn't make sense to call anything other than
shmem_writeout() as the ttm_backup deals only with shmem folios.

Have DRM_TTM config option select SHMEM to guarantee that
shmem_writeout() is available.

Link: https://lore.kernel.org/all/20250602170500.48713a2b@gandalf.local.home/
Suggested-by: Hugh Dickins <hughd@google.com>
Fixes: 84798514db50 ("mm: Remove swap_writepage() and shmem_writepage()")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/drm/Kconfig

index f094797f3b2bb5301d0fc4bf65f7cb5166f844d7..ded28c71d89cc1b0f6ce99ee8ef24194b5245a1d 100644 (file)
@@ -188,6 +188,7 @@ source "drivers/gpu/drm/display/Kconfig"
 config DRM_TTM
        tristate
        depends on DRM && MMU
+       select SHMEM
        help
          GPU memory management subsystem for devices with multiple
          GPU memory types. Will be enabled automatically if a device driver