dmaengine: moxart-dma: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919133207.1400430-28-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/dma/moxart-dma.c b/drivers/dma/moxart-dma.c
index 7565ad98ba6604e0fddcf0f174d929c51b00323c..a03953b3016bbb601d6259d259b05ceaaeccafc6 100644 (file)
--- a/drivers/dma/moxart-dma.c
+++ b/drivers/dma/moxart-dma.c
@@ -630,7 +630,7 @@ static int moxart_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int moxart_remove(struct platform_device *pdev)
+static void moxart_remove(struct platform_device *pdev)
 {
        struct moxart_dmadev *m = platform_get_drvdata(pdev);
 
@@ -640,8 +640,6 @@ static int moxart_remove(struct platform_device *pdev)
 
        if (pdev->dev.of_node)
                of_dma_controller_free(pdev->dev.of_node);
-
-       return 0;
 }
 
 static const struct of_device_id moxart_dma_match[] = {
@@ -652,7 +650,7 @@ MODULE_DEVICE_TABLE(of, moxart_dma_match);
 
 static struct platform_driver moxart_driver = {
        .probe  = moxart_probe,
-       .remove = moxart_remove,
+       .remove_new = moxart_remove,
        .driver = {
                .name           = "moxart-dma-engine",
                .of_match_table = moxart_dma_match,