]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: rockchip: Remove redundant PCIe message routing definitions
authorHans Zhang <18255117159@163.com>
Sat, 7 Jun 2025 15:49:13 +0000 (23:49 +0800)
committerManivannan Sadhasivam <mani@kernel.org>
Thu, 19 Jun 2025 12:53:57 +0000 (18:23 +0530)
The Rockchip driver contains duplicated message routing and INTx code
definitions (e.g., ROCKCHIP_PCIE_MSG_ROUTING_TO_RC,
ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTA). These are already provided by the
PCI core in drivers/pci/pci.h as PCIE_MSG_TYPE_R_RC and
PCIE_MSG_CODE_ASSERT_INTA, respectively.

Remove the driver-specific definitions in favor of the core definitions
instead. This aligns the driver with the PCIe specification and reduces
maintenance overhead.

Signed-off-by: Hans Zhang <18255117159@163.com>
[mani: commit message rewording]
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20250607154913.805027-3-18255117159@163.com
drivers/pci/controller/pcie-rockchip.h

index 5864a20323f21a004bfee4ac6d3a1328c4ab4d8a..12bc8da59d73bef0ba1c9e94da01e15aacd4b87f 100644 (file)
 #define RC_REGION_0_TYPE_MASK                  GENMASK(3, 0)
 #define MAX_AXI_WRAPPER_REGION_NUM             33
 
-#define ROCKCHIP_PCIE_MSG_ROUTING_TO_RC                0x0
-#define ROCKCHIP_PCIE_MSG_ROUTING_VIA_ADDR             0x1
-#define ROCKCHIP_PCIE_MSG_ROUTING_VIA_ID               0x2
-#define ROCKCHIP_PCIE_MSG_ROUTING_BROADCAST            0x3
-#define ROCKCHIP_PCIE_MSG_ROUTING_LOCAL_INTX           0x4
-#define ROCKCHIP_PCIE_MSG_ROUTING_PME_ACK              0x5
-#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTA             0x20
-#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTB             0x21
-#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTC             0x22
-#define ROCKCHIP_PCIE_MSG_CODE_ASSERT_INTD             0x23
-#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTA           0x24
-#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTB           0x25
-#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTC           0x26
-#define ROCKCHIP_PCIE_MSG_CODE_DEASSERT_INTD           0x27
 #define ROCKCHIP_PCIE_MSG_ROUTING_MASK                 GENMASK(7, 5)
 #define ROCKCHIP_PCIE_MSG_ROUTING(route) \
        (((route) << 5) & ROCKCHIP_PCIE_MSG_ROUTING_MASK)