]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panel: novatek-nt35560: avoid on-stack device structure
authorArnd Bergmann <arnd@arndb.de>
Thu, 4 Dec 2025 09:45:45 +0000 (10:45 +0100)
committerDouglas Anderson <dianders@chromium.org>
Thu, 4 Dec 2025 17:25:49 +0000 (09:25 -0800)
A cleanup patch apparently by accident used a local device structure
instead of a pointer to one in the nt35560_read_id() function, causing
a warning about stack usage:

drivers/gpu/drm/panel/panel-novatek-nt35560.c: In function 'nt35560_read_id':
drivers/gpu/drm/panel/panel-novatek-nt35560.c:249:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]

Change this to a pointer as was liley intended here.

Fixes: 5fbc0dbb92d6 ("drm/panel: novatek-nt35560: Clean up driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patch.msgid.link/20251204094550.1030506-1-arnd@kernel.org
drivers/gpu/drm/panel/panel-novatek-nt35560.c

index 561e6643dcbb673e0859859b475a289a21203e7f..6e5173f98a226498dc5983a701179ab8e37d03db 100644 (file)
@@ -213,7 +213,7 @@ static const struct backlight_properties nt35560_bl_props = {
 
 static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx)
 {
-       struct device dev = dsi_ctx->dsi->dev;
+       struct device *dev = &dsi_ctx->dsi->dev;
        u8 vendor, version, panel;
        u16 val;
 
@@ -225,7 +225,7 @@ static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx)
                return;
 
        if (vendor == 0x00) {
-               dev_err(&dev, "device vendor ID is zero\n");
+               dev_err(dev, "device vendor ID is zero\n");
                dsi_ctx->accum_err = -ENODEV;
                return;
        }
@@ -236,12 +236,12 @@ static void nt35560_read_id(struct mipi_dsi_multi_context *dsi_ctx)
        case DISPLAY_SONY_ACX424AKP_ID2:
        case DISPLAY_SONY_ACX424AKP_ID3:
        case DISPLAY_SONY_ACX424AKP_ID4:
-               dev_info(&dev,
+               dev_info(dev,
                         "MTP vendor: %02x, version: %02x, panel: %02x\n",
                         vendor, version, panel);
                break;
        default:
-               dev_info(&dev,
+               dev_info(dev,
                         "unknown vendor: %02x, version: %02x, panel: %02x\n",
                         vendor, version, panel);
                break;