]> git.ipfire.org Git - thirdparty/git.git/commitdiff
transport-helper: fix leaking import/export marks
authorPatrick Steinhardt <ps@pks.im>
Tue, 5 Nov 2024 06:17:23 +0000 (07:17 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 5 Nov 2024 06:37:54 +0000 (22:37 -0800)
Fix leaking import and export marks for transport helpers.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5801-remote-helpers.sh
transport-helper.c

index d21877150ed82e20a7984d83ec685cfd3e2f571d..d4882288a30ca056c83201b3f1ce9d29fbd07014 100755 (executable)
@@ -8,6 +8,7 @@ test_description='Test remote-helper import and export commands'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-gpg.sh
 
index 013ec79dc9cdc54094c37262381350a0bfa43731..bc27653cdee211bd68cfc624b0fefd66fa1917fc 100644 (file)
@@ -399,6 +399,8 @@ static int release_helper(struct transport *transport)
        int res = 0;
        struct helper_data *data = transport->data;
        refspec_clear(&data->rs);
+       free(data->import_marks);
+       free(data->export_marks);
        res = disconnect_helper(transport);
        free(transport->data);
        return res;