ipmi: use correct string length

gcc-8 reports

drivers/char/ipmi/ipmi_msghandler.c: In function
'panic_op_write_handler':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 16 equals destination size [-Wstringop-truncation]

drivers/char/ipmi/ipmi_watchdog.c: In function 'set_param_str':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 16 equals destination size [-Wstringop-truncation]

We need one less byte or call strlcpy() to make it a nul-terminated
string.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index f45732a2cb3e06d4830fd27b1f926a0b8ef2d0ca..01fbffb3168e8cd5e089837c71430e2bf528d701 100644 (file)
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -84,7 +84,7 @@ static int panic_op_write_handler(const char *val,
        char valcp[16];
        char *s;
 
-       strncpy(valcp, val, 16);
+       strncpy(valcp, val, 15);
        valcp[15] = '\0';
 
        s = strstrip(valcp);

diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 09e8463e480f4b3e8f0cb4d38e2d658e7234d945..775887977cbcf70536ee0beeb01fe2dc7c99b39b 100644 (file)
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -232,7 +232,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
        char       valcp[16];
        char       *s;
 
-       strncpy(valcp, val, 16);
+       strncpy(valcp, val, 15);
        valcp[15] = '\0';
 
        s = strstrip(valcp);