auth3: Remove auth_script

Did this ever really work?

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Dec  2 22:47:24 UTC 2019 on sn-devel-184

diff --git a/source3/auth/auth_script.c b/source3/auth/auth_script.c
deleted file mode 100644 (file)
index fae55e9..0000000
--- a/source3/auth/auth_script.c
+++ /dev/null
@@ -1,187 +0,0 @@
-/* 
-   Unix SMB/CIFS implementation.
-
-   Call out to a shell script for an authentication check.
-
-   Copyright (C) Jeremy Allison 2005.
-
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 3 of the License, or
-   (at your option) any later version.
-
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-
-   You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-#include "includes.h"
-#include "auth.h"
-
-#undef malloc
-
-#undef DBGC_CLASS
-#define DBGC_CLASS DBGC_AUTH
-
-/* Create a string containing the supplied :
- * domain\n
- * user\n
- * ascii hex challenge\n
- * ascii hex LM response\n
- * ascii hex NT response\n\0
- * and execute a shell script to check this.
- * Allows external programs to create users on demand.
- * Script returns zero on success, non-zero on fail.
- */
-
-static NTSTATUS script_check_user_credentials(const struct auth_context *auth_context,
-                                       void *my_private_data, 
-                                       TALLOC_CTX *mem_ctx,
-                                       const struct auth_usersupplied_info *user_info,
-                                       struct auth_serversupplied_info **server_info)
-{
-       const char *script = lp_parm_const_string( GLOBAL_SECTION_SNUM, "auth_script", "script", NULL);
-       char *secret_str;
-       size_t secret_str_len;
-       char hex_str[49];
-       int ret, i;
-
-       if (!script) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
-       if (!user_info) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
-       if (!auth_context) {
-               DEBUG(3,("script_check_user_credentials: no auth_info !\n"));
-               return NT_STATUS_INVALID_PARAMETER;
-       }               
-
-       secret_str_len = strlen(user_info->mapped.domain_name) + 1 +
-                       strlen(user_info->client.account_name) + 1 +
-                       16 + 1 + /* 8 bytes of challenge going to 16 */
-                       48 + 1 + /* 24 bytes of challenge going to 48 */
-                       48 + 1;
-
-       secret_str = (char *)malloc(secret_str_len);
-       if (!secret_str) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       if (strlcpy( secret_str, user_info->mapped.domain_name, secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-       if (strlcat( secret_str, "\n", secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-       if (strlcat( secret_str, user_info->client.account_name, secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-       if (strlcat( secret_str, "\n", secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-
-       for (i = 0; i < 8; i++) {
-               slprintf(&hex_str[i*2], 3, "%02X", auth_context->challenge.data[i]);
-       }
-       if (strlcat( secret_str, hex_str, secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-       if (strlcat( secret_str, "\n", secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-
-       if (user_info->password.response.lanman.data) {
-               for (i = 0; i < 24; i++) {
-                       slprintf(&hex_str[i*2], 3, "%02X", user_info->password.response.lanman.data[i]);
-               }
-               if (strlcat( secret_str, hex_str, secret_str_len) >= secret_str_len) {
-                       /* Truncate. */
-                       goto cat_out;
-               }
-       }
-       if (strlcat( secret_str, "\n", secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-
-       if (user_info->password.response.nt.data) {
-               for (i = 0; i < 24; i++) {
-                       slprintf(&hex_str[i*2], 3, "%02X", user_info->password.response.nt.data[i]);
-               }
-               if (strlcat( secret_str, hex_str, secret_str_len) >= secret_str_len) {
-                       /* Truncate. */
-                       goto cat_out;
-               }
-       }
-       if (strlcat( secret_str, "\n", secret_str_len) >= secret_str_len) {
-               /* Truncate. */
-               goto cat_out;
-       }
-
-       DEBUG(10,("script_check_user_credentials: running %s with parameters:\n%s\n",
-               script, secret_str ));
-
-       ret = smbrunsecret( script, secret_str);
-
-       SAFE_FREE(secret_str);
-
-       if (ret) {
-               DEBUG(1,("script_check_user_credentials: failed to authenticate %s\\%s\n",
-                       user_info->mapped.domain_name, user_info->client.account_name ));
-               /* auth failed. */
-               return NT_STATUS_NO_SUCH_USER;
-       }
-
-       /* Cause the auth system to keep going.... */
-       return NT_STATUS_NOT_IMPLEMENTED;
-
-  cat_out:
-
-       SAFE_FREE(secret_str);
-       return NT_STATUS_NO_MEMORY;
-}
-
-/* module initialisation */
-static NTSTATUS auth_init_script(struct auth_context *auth_context, const char *param, auth_methods **auth_method) 
-{
-       struct auth_methods *result;
-
-       result = talloc_zero(auth_context, struct auth_methods);
-       if (result == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       result->name = "script";
-       result->auth = script_check_user_credentials;
-
-       if (param && *param) {
-               /* we load the 'fallback' module - if script isn't here, call this
-                  module */
-               auth_methods *priv;
-               if (!load_auth_module(auth_context, param, &priv)) {
-                       return NT_STATUS_UNSUCCESSFUL;
-               }
-               result->private_data = (void *)priv;
-       }
-
-        *auth_method = result;
-       return NT_STATUS_OK;
-}
-
-NTSTATUS auth_script_init(TALLOC_CTX *);
-NTSTATUS auth_script_init(TALLOC_CTX *ctx)
-{
-       return smb_register_auth(AUTH_INTERFACE_VERSION, "script", auth_init_script);
-}

diff --git a/source3/auth/wscript_build b/source3/auth/wscript_build
index c1062199aa86288c57d394a060f6c32e283b4816..277c43065576f57a2710ebc48af20ced8ae72240 100644 (file)
--- a/source3/auth/wscript_build
+++ b/source3/auth/wscript_build
@@ -53,13 +53,6 @@ bld.SAMBA3_MODULE('auth_builtin',
                  init_function='',
                  internal_module=True)
 
-bld.SAMBA3_MODULE('auth_script',
-                 subsystem='auth',
-                 source='auth_script.c',
-                 init_function='',
-                 internal_module=bld.SAMBA3_IS_STATIC_MODULE('auth_script'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('auth_script'))
-
 bld.SAMBA3_MODULE('auth_samba4',
                   subsystem='auth',
                   source='auth_samba4.c',

diff --git a/source3/wscript b/source3/wscript
index f3d0c7d7f34594ea775a67832a8be6ade7ec662b..bfe47c6311343ce8b70c1635d8b6c6564881c7d5 100644 (file)
--- a/source3/wscript
+++ b/source3/wscript
@@ -1899,7 +1899,7 @@ main() {
                                       vfs_commit vfs_worm vfs_crossrename vfs_linux_xfs_sgid
                                       vfs_time_audit vfs_offline vfs_virusfilter
                                   '''))
-    default_shared_modules.extend(TO_LIST('auth_script idmap_tdb2 idmap_script'))
+    default_shared_modules.extend(TO_LIST('idmap_tdb2 idmap_script'))
     # these have broken dependencies
     forced_shared_modules.extend(TO_LIST('idmap_autorid idmap_rid idmap_hash'))