lib-http: client: Fix segfault by making the initialization of the connection after...

Before, the connection was not guaranteed to be fully initialized after the SSL
handshake. The problem would occur when the handshake finished while writing the
SSL output stream.

diff --git a/src/lib-http/http-client-connection.c b/src/lib-http/http-client-connection.c
index 4411db7b89ed5caa396638cf6ea6b9d100af7d29..6b0a8ffa03ca3e90040ec6f73598aa96c5922566 100644 (file)
--- a/src/lib-http/http-client-connection.c
+++ b/src/lib-http/http-client-connection.c
@@ -979,8 +979,10 @@ static void http_client_connection_input(struct connection *_conn)
                        i_assert(ret == 0);
                        return;
                }
+       }
 
-               /* ready for first request */
+       if (!conn->connect_succeeded) {
+               /* just got ready for first request */
                http_client_connection_ready(conn);
        }
 
@@ -1353,6 +1355,7 @@ http_client_connection_ready(struct http_client_connection *conn)
        const struct http_client_settings *set = &peer->client->set;
 
        e_debug(conn->event, "Ready for requests");
+       i_assert(!conn->connect_succeeded);
 
        /* connected */
        conn->connected = TRUE;