]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RDMA/qib: Fix truncation compilation warnings in qib_init.c
authorLeon Romanovsky <leonro@nvidia.com>
Mon, 1 Jul 2024 12:42:28 +0000 (15:42 +0300)
committerLeon Romanovsky <leon@kernel.org>
Thu, 4 Jul 2024 04:56:47 +0000 (07:56 +0300)
drivers/infiniband/hw/qib/qib_init.c: In function ‘qib_init_one’:
drivers/infiniband/hw/qib/qib_init.c:586:67: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size between 0 and 3 [-Werror=format-truncation=]
  586 |                         snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
      |                                                                   ^~
In function ‘qib_create_workqueues’,
    inlined from ‘qib_init_one’ at drivers/infiniband/hw/qib/qib_init.c:1438:8:
drivers/infiniband/hw/qib/qib_init.c:586:60: note: directive argument in the range [-2147483643, 254]
  586 |                         snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
      |                                                            ^~~~~~~~~~
drivers/infiniband/hw/qib/qib_init.c:586:25: note: ‘snprintf’ output between 7 and 27 bytes into a destination of size 8
  586 |                         snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  587 |                                 dd->unit, pidx);
      |                                 ~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Link: https://lore.kernel.org/r/ab5222c414a01e9d2c5129ef26836aace9ee2aa5.1719837715.git.leon@kernel.org
Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
drivers/infiniband/hw/qib/qib_init.c

index 33667becd52b047b1988a2735c66f059e9159009..db3b25c8433a17f8def3c7b2b87373e312829e55 100644 (file)
@@ -581,7 +581,7 @@ static int qib_create_workqueues(struct qib_devdata *dd)
        for (pidx = 0; pidx < dd->num_pports; ++pidx) {
                ppd = dd->pport + pidx;
                if (!ppd->qib_wq) {
-                       char wq_name[8]; /* 3 + 2 + 1 + 1 + 1 */
+                       char wq_name[23];
 
                        snprintf(wq_name, sizeof(wq_name), "qib%d_%d",
                                dd->unit, pidx);