ASoC: nau8821: check regmap_raw_read/regmap_raw_write for failure

The return values from both regmap_raw_read() and regmap_raw_write() are not
checked despite they can fail. Propagate possible errors to caller.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: Vitaliy Shevtsov <v.shevtsov@maxima.ru>
Link: https://patch.msgid.link/20241018110743.18786-1-v.shevtsov@maxima.ru
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c
index de5c4db05c8f8b6a1c7f12b23e5850aae0742cba..edb95f869a4a6ba63622b2d27d7b359c6aeea5ef 100644 (file)
--- a/sound/soc/codecs/nau8821.c
+++ b/sound/soc/codecs/nau8821.c
@@ -287,10 +287,8 @@ static int nau8821_biq_coeff_get(struct snd_kcontrol *kcontrol,
        if (!component->regmap)
                return -EINVAL;
 
-       regmap_raw_read(component->regmap, NAU8821_R21_BIQ0_COF1,
+       return regmap_raw_read(component->regmap, NAU8821_R21_BIQ0_COF1,
                ucontrol->value.bytes.data, params->max);
-
-       return 0;
 }
 
 static int nau8821_biq_coeff_put(struct snd_kcontrol *kcontrol,
@@ -299,6 +297,7 @@ static int nau8821_biq_coeff_put(struct snd_kcontrol *kcontrol,
        struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
        struct soc_bytes_ext *params = (void *)kcontrol->private_value;
        void *data;
+       int ret;
 
        if (!component->regmap)
                return -EINVAL;
@@ -308,12 +307,12 @@ static int nau8821_biq_coeff_put(struct snd_kcontrol *kcontrol,
        if (!data)
                return -ENOMEM;
 
-       regmap_raw_write(component->regmap, NAU8821_R21_BIQ0_COF1,
+       ret = regmap_raw_write(component->regmap, NAU8821_R21_BIQ0_COF1,
                data, params->max);
 
        kfree(data);
 
-       return 0;
+       return ret;
 }
 
 static const char * const nau8821_adc_decimation[] = {