Don't loop forever when tty returns NUL bytes

Somehow a user was running into a case where plymouthd
would busy loop taking 100% cpu.  gdb revealed that it
was stuck trying to process keyboard input.  This is
apparently because we were looping forever when mbrlen()
got a NUL byte.

diff --git a/src/libplybootsplash/ply-window.c b/src/libplybootsplash/ply-window.c
index e0222cde53cc00968993a0e283d9829430a324a2..d3c9e790ec75369aeb6b144221f7ea568460441f 100644 (file)
--- a/src/libplybootsplash/ply-window.c
+++ b/src/libplybootsplash/ply-window.c
@@ -354,6 +354,14 @@ check_buffer_for_key_events (ply_window_t *window)
       if (character_size < 0)
         break;
 
+      /* If we're at a NUL character walk through it
+       */
+      if (character_size == 0)
+        {
+          i++;
+          continue;
+        }
+
       keyboard_input = strndup (bytes + i, character_size);
 
       process_keyboard_input (window, keyboard_input, character_size);