]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Turn off qualify on uncached realtime peers.
authorTilghman Lesher <tilghman@meg.abyt.es>
Fri, 31 Oct 2008 16:30:32 +0000 (16:30 +0000)
committerTilghman Lesher <tilghman@meg.abyt.es>
Fri, 31 Oct 2008 16:30:32 +0000 (16:30 +0000)
(Closes issue #13383)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@153114 65c4cc65-6c06-0410-ace0-fbb531ad65f3

channels/chan_sip.c

index 979b5de50344838105b7f5a9177e4939ff86a5d2..b040238c204052b1681a5de85a197e5b2bc880dd 100644 (file)
@@ -17326,6 +17326,14 @@ static struct sip_peer *build_peer(const char *name, struct ast_variable *v, str
                                ast_log(LOG_WARNING, "Qualification of peer '%s' should be 'yes', 'no', or a number of milliseconds at line %d of sip.conf\n", peer->name, v->lineno);
                                peer->maxms = 0;
                        }
+                       if (realtime && !ast_test_flag(&global_flags[1], SIP_PAGE2_RTCACHEFRIENDS) && peer->maxms > 0) {
+                               /* This would otherwise cause a network storm, where the
+                                * qualify response refreshes the peer from the database,
+                                * which in turn causes another qualify to be sent, ad
+                                * infinitum. */
+                               ast_log(LOG_WARNING, "Qualify is incompatible with dynamic uncached realtime.  Please either turn rtcachefriends on or turn qualify off on peer '%s'\n", peer->name);
+                               peer->maxms = 0;
+                       }
                } else if (!strcasecmp(v->name, "maxcallbitrate")) {
                        peer->maxcallbitrate = atoi(v->value);
                        if (peer->maxcallbitrate < 0)