]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
manual: Fix compiler errors in inetsrv example.
authorCollin Funk <collin.funk1@gmail.com>
Sun, 28 Sep 2025 22:34:20 +0000 (15:34 -0700)
committerCollin Funk <collin.funk1@gmail.com>
Tue, 30 Sep 2025 00:01:54 +0000 (17:01 -0700)
Previously this file failed to compile with the following errors:

    $ gcc manual/examples/inetsrv.c
    manual/examples/inetsrv.c: In function ‘main’:
    manual/examples/inetsrv.c:97:31: error: passing argument 3 of ‘accept’ from incompatible pointer type [-Wincompatible-pointer-types]
       97 |                               &size);
          |                               ^~~~~
          |                               |
          |                               size_t * {aka long unsigned int *}
    In file included from manual/examples/inetsrv.c:23:
    /usr/include/sys/socket.h:307:42: note: expected ‘socklen_t * restrict’ {aka ‘unsigned int * restrict’} but argument is of type ‘size_t *’ {aka ‘long unsigned int *’}
      307 |                    socklen_t *__restrict __addr_len);
          |                    ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
    manual/examples/inetsrv.c:105:26: error: implicit declaration of function ‘inet_ntoa’ [-Wimplicit-function-declaration]
      105 |                          inet_ntoa (clientname.sin_addr),

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
manual/examples/inetsrv.c

index 003a95147330b653c50a2e93e14a855bf180e9ba..b854fe6722db9067b9b0a43a3c7e8ffd055c5858 100644 (file)
@@ -15,6 +15,7 @@
    along with this program; if not, see <https://www.gnu.org/licenses/>.
 */
 
+#include <arpa/inet.h>
 #include <stdio.h>
 #include <errno.h>
 #include <stdlib.h>
@@ -59,7 +60,7 @@ main (void)
   fd_set active_fd_set, read_fd_set;
   int i;
   struct sockaddr_in clientname;
-  size_t size;
+  socklen_t size;
 
   /* Create the socket and set it up to accept connections. */
   sock = make_socket (PORT);