]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ata: pata_isapnp: Add missing error check for devm_ioport_map()
authorChen Ni <nichen@iscas.ac.cn>
Tue, 31 Oct 2023 04:00:07 +0000 (04:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Dec 2023 07:41:58 +0000 (08:41 +0100)
[ Upstream commit a6925165ea82b7765269ddd8dcad57c731aa00de ]

Add missing error return check for devm_ioport_map() and return the
error if this function call fails.

Fixes: 0d5ff566779f ("libata: convert to iomap")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ata/pata_isapnp.c

index 994f168b54a804184ebb01b20b8acda16230e62d..4ffbc2a63f8f5645b1d3813b42d1988285e5053c 100644 (file)
@@ -81,6 +81,9 @@ static int isapnp_init_one(struct pnp_dev *idev, const struct pnp_device_id *dev
        if (pnp_port_valid(idev, 1)) {
                ctl_addr = devm_ioport_map(&idev->dev,
                                           pnp_port_start(idev, 1), 1);
+               if (!ctl_addr)
+                       return -ENOMEM;
+
                ap->ioaddr.altstatus_addr = ctl_addr;
                ap->ioaddr.ctl_addr = ctl_addr;
                ap->ops = &isapnp_port_ops;