auth: auth_worker_call() - Return void instead of the connection

The return value is no longer necessary, and it most likely would just be
used wrong.

diff --git a/src/auth/auth-worker-server.c b/src/auth/auth-worker-server.c
index 16617528289d4fb1cecdeab7903ea36d6d1315a3..41b2b2bb486375cec5d9f6871e82e96d8e007b03 100644 (file)
--- a/src/auth/auth-worker-server.c
+++ b/src/auth/auth-worker-server.c
@@ -442,9 +442,8 @@ static void worker_input_resume(struct auth_worker_connection *conn)
        worker_input(conn);
 }
 
-struct auth_worker_connection *
-auth_worker_call(pool_t pool, const char *username, const char *data,
-                auth_worker_callback_t *callback, void *context)
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+                     auth_worker_callback_t *callback, void *context)
 {
        struct auth_worker_connection *conn;
        struct auth_worker_request *request;
@@ -474,7 +473,6 @@ auth_worker_call(pool_t pool, const char *username, const char *data,
                /* reached the limit, queue the request */
                aqueue_append(worker_request_queue, &request);
        }
-       return conn;
 }
 
 void auth_worker_server_resume_input(struct auth_worker_connection *conn)

diff --git a/src/auth/auth-worker-server.h b/src/auth/auth-worker-server.h
index 6b1b2414462113f7b6ef154c23d63ee9885d1be7..d2a30634a3876c8ea6e4ab9056a25ab077828b86 100644 (file)
--- a/src/auth/auth-worker-server.h
+++ b/src/auth/auth-worker-server.h
@@ -8,9 +8,8 @@ struct auth_worker_connection;
 typedef bool auth_worker_callback_t(struct auth_worker_connection *conn,
                                    const char *reply, void *context);
 
-struct auth_worker_connection * ATTR_NOWARN_UNUSED_RESULT
-auth_worker_call(pool_t pool, const char *username, const char *data,
-                auth_worker_callback_t *callback, void *context);
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+                     auth_worker_callback_t *callback, void *context);
 void auth_worker_server_resume_input(struct auth_worker_connection *conn);
 
 void auth_worker_server_init(void);