gpu: host1x: mipi: Benefit from devm_clk_get_prepared()

When using devm_clk_get_prepared() instead of devm_clk_get() the clock
is already returned prepared. So probe doesn't need to call
clk_prepare() and at remove time the call to clk_unprepare() can be
dropped. The latter makes the remove callback empty, so it can be
dropped, too.

Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20240409165043.105137-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index 4dcec535ec21cd7cfc47b23c89f6fb2184186415..e51b43dd15a317aa431fc71f3acd70f87d887b63 100644 (file)
--- a/drivers/gpu/host1x/mipi.c
+++ b/drivers/gpu/host1x/mipi.c
@@ -501,7 +501,6 @@ static int tegra_mipi_probe(struct platform_device *pdev)
 {
        const struct of_device_id *match;
        struct tegra_mipi *mipi;
-       int err;
 
        match = of_match_node(tegra_mipi_of_match, pdev->dev.of_node);
        if (!match)
@@ -520,35 +519,21 @@ static int tegra_mipi_probe(struct platform_device *pdev)
 
        mutex_init(&mipi->lock);
 
-       mipi->clk = devm_clk_get(&pdev->dev, NULL);
+       mipi->clk = devm_clk_get_prepared(&pdev->dev, NULL);
        if (IS_ERR(mipi->clk)) {
                dev_err(&pdev->dev, "failed to get clock\n");
                return PTR_ERR(mipi->clk);
        }
 
-       err = clk_prepare(mipi->clk);
-       if (err < 0)
-               return err;
-
        platform_set_drvdata(pdev, mipi);
 
        return 0;
 }
 
-static int tegra_mipi_remove(struct platform_device *pdev)
-{
-       struct tegra_mipi *mipi = platform_get_drvdata(pdev);
-
-       clk_unprepare(mipi->clk);
-
-       return 0;
-}
-
 struct platform_driver tegra_mipi_driver = {
        .driver = {
                .name = "tegra-mipi",
                .of_match_table = tegra_mipi_of_match,
        },
        .probe = tegra_mipi_probe,
-       .remove = tegra_mipi_remove,
 };