]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
curl: error on --alt-svc use w/o support
authorDaniel Stenberg <daniel@haxx.se>
Tue, 4 Feb 2020 16:32:55 +0000 (17:32 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Wed, 5 Feb 2020 06:57:38 +0000 (07:57 +0100)
Make the tool check for alt-svc support at run-time and return error
accordingly if not present when the option is used.

Reported-by: Harry Sintonen
Closes #4878

src/tool_getparam.c
src/tool_operate.c

index 1a72edf3ee149682fe394d3599568a882c672a63..764caa203acde663904c0003b19e94d21e264aee 100644 (file)
@@ -1278,7 +1278,10 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
     case 'b':
       switch(subletter) {
       case 'a': /* --alt-svc */
-        GetStr(&config->altsvc, nextarg);
+        if(curlinfo->features & CURL_VERSION_ALTSVC)
+          GetStr(&config->altsvc, nextarg);
+        else
+          return PARAM_LIBCURL_DOESNT_SUPPORT;
         break;
       default:  /* --cookie string coming up: */
         if(nextarg[0] == '@') {
index 2855f0f8f8ea0e2f6e2c2de64999664291463ae8..4b3caa80c99635c0d2834dad40b792d62d7349ea 100644 (file)
@@ -1966,11 +1966,8 @@ static CURLcode single_transfer(struct GlobalConfig *global,
         if(config->disallow_username_in_url)
           my_setopt(curl, CURLOPT_DISALLOW_USERNAME_IN_URL, 1L);
 
-#ifdef USE_ALTSVC
-        /* only if explicitly enabled in configure */
         if(config->altsvc)
           my_setopt_str(curl, CURLOPT_ALTSVC, config->altsvc);
-#endif
 
 #ifdef USE_METALINK
         if(!metalink && config->use_metalink) {