]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
cmd: fru: Simplify do_fru_capture()
authorMichal Simek <michal.simek@xilinx.com>
Tue, 16 Apr 2019 06:08:21 +0000 (08:08 +0200)
committerMichal Simek <michal.simek@xilinx.com>
Thu, 6 Jun 2019 11:46:52 +0000 (13:46 +0200)
Remove ret and check already recorded maximum number of args via
cmdtp->maxargs.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
cmd/fru.c

index b8efaad26813465e2808b7cbde0963aaf2486dc0..5e3363ec26173eb33b6cea1e3ce5ef54b5c89dda 100644 (file)
--- a/cmd/fru.c
+++ b/cmd/fru.c
@@ -14,18 +14,15 @@ static int do_fru_capture(cmd_tbl_t *cmdtp, int flag, int argc,
 {
        unsigned long addr;
        char *endp;
-       int ret;
 
-       if (argc < 3)
+       if (argc < cmdtp->maxargs)
                return CMD_RET_USAGE;
 
        addr = simple_strtoul(argv[2], &endp, 16);
-       if (*argv[1] == 0 || *endp != 0)
+       if (*argv[1] == 0 || *endp != 0) /* FIXME */
                return -1;
 
-       ret = fru_capture(addr);
-
-       return ret;
+       return fru_capture(addr);
 }
 
 static int do_fru_display(cmd_tbl_t *cmdtp, int flag, int argc,