]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
jbd2: drop pointless shrinker batch initialization
authorJan Kara <jack@suse.cz>
Mon, 24 Jun 2024 17:01:20 +0000 (19:01 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 9 Jul 2024 03:59:37 +0000 (23:59 -0400)
In jbd2_journal_init_common() we set batch size of a shrinker shrinking
checkpointed buffers to journal->j_max_transaction_buffers. But that is
guaranteed to be 0 at that point so we effectively stay with the default
shrinker batch size of 128. It has been like this since introduction of
jbd2 shrinkers so just drop the pointless initialization.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20240624170127.3253-4-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c

index 2ae861abf77098ff8eb8e12bf207d013e99ea5f6..25d373fac2f2fb3706d2827409311b91cb50e764 100644 (file)
@@ -1617,7 +1617,6 @@ static journal_t *journal_init_common(struct block_device *bdev,
 
        journal->j_shrinker->scan_objects = jbd2_journal_shrink_scan;
        journal->j_shrinker->count_objects = jbd2_journal_shrink_count;
-       journal->j_shrinker->batch = journal->j_max_transaction_buffers;
        journal->j_shrinker->private_data = journal;
 
        shrinker_register(journal->j_shrinker);