Stop sending the current time in client NETINFO handshakes.

Implements part of proposal 222.

diff --git a/changes/no_client_timestamps_024 b/changes/no_client_timestamps_024
new file mode 100644 (file)
index 0000000..6df5307
--- /dev/null
+++ b/changes/no_client_timestamps_024
@@ -0,0 +1,5 @@
+  o Minor features (security):
+    - Clients no longer send timestamps in their NETINFO cells.  These were
+      not used for anything, and they provided one small way for clients
+      to be distinguished from each other as they moved from network to
+      network or behind NAT.

diff --git a/src/or/connection_or.c b/src/or/connection_or.c
index d5dd4470e33bf38d7d7a6dff660cd53f3c0598ea..95cb39ac8917c8788e08eea770e6eb7816653aa1 100644 (file)
--- a/src/or/connection_or.c
+++ b/src/or/connection_or.c
@@ -2051,8 +2051,9 @@ connection_or_send_netinfo(or_connection_t *conn)
   memset(&cell, 0, sizeof(cell_t));
   cell.command = CELL_NETINFO;
 
-  /* Timestamp. */
-  set_uint32(cell.payload, htonl((uint32_t)now));
+  /* Timestamp, if we're a relay. */
+  if (! conn->handshake_state->started_here)
+    set_uint32(cell.payload, htonl((uint32_t)now));
 
   /* Their address. */
   out = cell.payload + 4;