drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

Do not create a custom directory in debugfs-root, but use the
debugfs_init callback to create a custom directory at the given place
for the bridge. The new directory layout looks like this on a Renesas
GrayHawk-Single with a R-Car V4M SoC:

	/sys/kernel/debug/dri/feb00000.display/DP-1/1-002c

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250315201651.7339-2-wsa+renesas@sang-engineering.com

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index fd68ad2e27186c24cef20dd4ae20decdd6da4a2e..c2bdc7e57ac7937b2235eecc0dbd40bd5b92ee3e 100644 (file)
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -440,36 +440,8 @@ static int status_show(struct seq_file *s, void *data)
 
        return 0;
 }
-
 DEFINE_SHOW_ATTRIBUTE(status);
 
-static void ti_sn65dsi86_debugfs_remove(void *data)
-{
-       debugfs_remove_recursive(data);
-}
-
-static void ti_sn65dsi86_debugfs_init(struct ti_sn65dsi86 *pdata)
-{
-       struct device *dev = pdata->dev;
-       struct dentry *debugfs;
-       int ret;
-
-       debugfs = debugfs_create_dir(dev_name(dev), NULL);
-
-       /*
-        * We might get an error back if debugfs wasn't enabled in the kernel
-        * so let's just silently return upon failure.
-        */
-       if (IS_ERR_OR_NULL(debugfs))
-               return;
-
-       ret = devm_add_action_or_reset(dev, ti_sn65dsi86_debugfs_remove, debugfs);
-       if (ret)
-               return;
-
-       debugfs_create_file("status", 0600, debugfs, pdata, &status_fops);
-}
-
 /* -----------------------------------------------------------------------------
  * Auxiliary Devices (*not* AUX)
  */
@@ -1238,6 +1210,15 @@ static const struct drm_edid *ti_sn_bridge_edid_read(struct drm_bridge *bridge,
        return drm_edid_read_ddc(connector, &pdata->aux.ddc);
 }
 
+static void ti_sn65dsi86_debugfs_init(struct drm_bridge *bridge, struct dentry *root)
+{
+       struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge);
+       struct dentry *debugfs;
+
+       debugfs = debugfs_create_dir(dev_name(pdata->dev), root);
+       debugfs_create_file("status", 0600, debugfs, pdata, &status_fops);
+}
+
 static const struct drm_bridge_funcs ti_sn_bridge_funcs = {
        .attach = ti_sn_bridge_attach,
        .detach = ti_sn_bridge_detach,
@@ -1251,6 +1232,7 @@ static const struct drm_bridge_funcs ti_sn_bridge_funcs = {
        .atomic_reset = drm_atomic_helper_bridge_reset,
        .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
        .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
+       .debugfs_init = ti_sn65dsi86_debugfs_init,
 };
 
 static void ti_sn_bridge_parse_lanes(struct ti_sn65dsi86 *pdata,
@@ -1959,8 +1941,6 @@ static int ti_sn65dsi86_probe(struct i2c_client *client)
        if (ret)
                return ret;
 
-       ti_sn65dsi86_debugfs_init(pdata);
-
        /*
         * Break ourselves up into a collection of aux devices. The only real
         * motiviation here is to solve the chicken-and-egg problem of probe