builtin/credential-store: fix leaking credential

We never free credentials read by the credential store, leading to a
memory leak. Plug it.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/credential-store.c b/builtin/credential-store.c
index 494c8093321e1dac30c019d178096efb26050874..97968bfa1c2d81c857016dd53a06bb61e43614f5 100644 (file)
--- a/builtin/credential-store.c
+++ b/builtin/credential-store.c
@@ -218,5 +218,6 @@ int cmd_credential_store(int argc, const char **argv, const char *prefix)
                ; /* Ignore unknown operation. */
 
        string_list_clear(&fns, 0);
+       credential_clear(&c);
        return 0;
 }

diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
index 716bf1af9fd04e64b7d5c03570b5ba74a8529d46..f83db659e2581444b9a9740df8cefd7fb530c359 100755 (executable)
--- a/t/t0302-credential-store.sh
+++ b/t/t0302-credential-store.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='credential-store tests'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh
 

diff --git a/t/t0303-credential-external.sh b/t/t0303-credential-external.sh
index 72ae405c3ed979edee54cbe83e73ec566d23f6d1..8aadbe86c458560f1e23811db10679c806c5a324 100755 (executable)
--- a/t/t0303-credential-external.sh
+++ b/t/t0303-credential-external.sh
@@ -29,6 +29,7 @@ you can set GIT_TEST_CREDENTIAL_HELPER_SETUP to a sequence of shell
 commands.
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh