]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/rcar-du: dsi: Deduplicate mipi_dsi_pixel_format_to_bpp() usage
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Tue, 28 Oct 2025 23:28:14 +0000 (00:28 +0100)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 29 Oct 2025 09:32:11 +0000 (11:32 +0200)
Call mipi_dsi_pixel_format_to_bpp() once in rcar_mipi_dsi_set_display_timing()
and store the value into a variable. This slightly simplifies the code.

No functional change.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Link: https://patch.msgid.link/20251028232959.109936-5-marek.vasut+renesas@mailbox.org
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c

index c24721a1eddf284ab5e4ab07f15541a6880fda1f..e13249e0134b44cc57026f391472e28060bdf997 100644 (file)
@@ -457,13 +457,17 @@ static void rcar_mipi_dsi_set_display_timing(struct rcar_mipi_dsi *dsi,
        u32 vprmset4r;
 
        /* Configuration for Pixel Stream and Packet Header */
-       if (mipi_dsi_pixel_format_to_bpp(dsi->format) == 24)
+       switch (mipi_dsi_pixel_format_to_bpp(dsi->format)) {
+       case 24:
                rcar_mipi_dsi_write(dsi, TXVMPSPHSETR, TXVMPSPHSETR_DT_RGB24);
-       else if (mipi_dsi_pixel_format_to_bpp(dsi->format) == 18)
+               break;
+       case 18:
                rcar_mipi_dsi_write(dsi, TXVMPSPHSETR, TXVMPSPHSETR_DT_RGB18);
-       else if (mipi_dsi_pixel_format_to_bpp(dsi->format) == 16)
+               break;
+       case 16:
                rcar_mipi_dsi_write(dsi, TXVMPSPHSETR, TXVMPSPHSETR_DT_RGB16);
-       else {
+               break;
+       default:
                dev_warn(dsi->dev, "unsupported format");
                return;
        }