]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mei: demote client disconnect warning on suspend to debug
authorAlexander Usyskin <alexander.usyskin@intel.com>
Thu, 30 May 2024 09:14:15 +0000 (12:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 4 Jun 2024 15:11:44 +0000 (17:11 +0200)
Change level for the "not connected" client message in the write
callback from error to debug.

The MEI driver currently disconnects all clients upon system suspend.
This behavior is by design and user-space applications with
open connections before the suspend are expected to handle errors upon
resume, by reopening their handles, reconnecting,
and retrying their operations.

However, the current driver implementation logs an error message every
time a write operation is attempted on a disconnected client.
Since this is a normal and expected flow after system resume
logging this as an error can be misleading.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20240530091415.725247-1-tomas.winkler@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/main.c

index 79e6f3c1341febe0921b32dd27c817887cb06855..40c3fe26f76df0a5a7fe192eb12d637f6b738056 100644 (file)
@@ -329,7 +329,7 @@ static ssize_t mei_write(struct file *file, const char __user *ubuf,
        }
 
        if (!mei_cl_is_connected(cl)) {
-               cl_err(dev, cl, "is not connected");
+               cl_dbg(dev, cl, "is not connected");
                rets = -ENODEV;
                goto out;
        }