]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: wrong logical statement in in_recovery_period() (BBR)
authorFrederic Lecaille <flecaille@haproxy.com>
Thu, 12 Dec 2024 09:45:26 +0000 (10:45 +0100)
committerFrederic Lecaille <flecaille@haproxy.com>
Fri, 13 Dec 2024 13:42:43 +0000 (14:42 +0100)
A && logical operator was badly replaced by a || in this function which decides
if BBR is in a recovery period.

Must be backported to 3.1.

src/quic_cc_bbr.c

index 39fd673df4b3a351c2ef13c9d6a469fd97798d96..9a3b0a83ea67dce46af92661d88680a58fe90bc3 100644 (file)
@@ -1296,7 +1296,7 @@ static void bbr_update_control_parameters(struct bbr *bbr,
 
 static inline int in_recovery_period(struct quic_cc_path *p, uint32_t ts)
 {
-       return tick_isset(p->recovery_start_ts) ||
+       return tick_isset(p->recovery_start_ts) &&
                tick_is_le(ts, p->recovery_start_ts);
 }