]> git.ipfire.org Git - people/ms/ipfire-2.x.git/commitdiff
samba.cgi: Use new service function
authorMichael Tremer <michael.tremer@ipfire.org>
Sat, 23 Mar 2024 18:09:44 +0000 (19:09 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Sat, 23 Mar 2024 18:09:44 +0000 (19:09 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/samba.cgi

index c60dca1d4804d723b7386367cfc3b2fd6c986d25..03ffba2e78f8a9fa7b558d1141c31ac51467bd1e 100644 (file)
@@ -182,35 +182,21 @@ $selected{'MAPTOGUEST'}{$sambasettings{'MAPTOGUEST'}} = "selected='selected'";
 
 &Header::openbox('100%', 'center', $Lang::tr{'samba'});
 
-my %servicenames = (
-       "nmbd"     => $Lang::tr{'netbios nameserver daemon'},
-       "smbd"     => $Lang::tr{'smb daemon'},
-       "winbindd" => $Lang::tr{'winbind daemon'},
-);
+&Header::ServiceStatus({
+       $Lang::tr{'netbios nameserver daemon'} => {
+               "process" => "nmbd",
+       },
 
-print <<END;
-       <table class="tbl" width='100%' cellspacing='0'>
-               <tr bgcolor='$color{'color20'}'>
-                       <td colspan='2' align='left'><b>$Lang::tr{'all services'}</b></td>
-               </tr>
-END
-
-foreach my $service (sort keys %servicenames) {
-       my $status = &isrunning($service);
+       $Lang::tr{'smb daemon'} => {
+               "process" => "smbd",
+       },
 
-       print <<END;
-               <tr>
-                       <td align='left' width='40%'>$servicenames{$service}</td>
-                       $status
-               </tr>
-END
-}
+       $Lang::tr{'winbind daemon'} => {
+               "process" => "winbindd",
+       }
+});
 
 print <<END
-       </table>
-
-       <br>
-
        <table width="100%">
                <td width="33%" align="center">
                        <form method="POST" action="$ENV{'SCRIPT_NAME'}">
@@ -738,40 +724,6 @@ close FILE;
 &General::system("/usr/local/bin/sambactrl", "smbreload");
 }
 
-sub isrunning
-       {
-       my $cmd = $_[0];
-       my $status = "<td align='center' bgcolor='${Header::colourred}'><font color='white'><b>$Lang::tr{'stopped'}</b></font></td>";
-       my $pid = '';
-       my $testcmd = '';
-       my $exename;
-
-       $cmd =~ /(^[a-z]+)/;
-       $exename = $1;
-
-       if (open(FILE, "/var/run/${cmd}.pid"))
-               {
-               $pid = <FILE>; chomp $pid;
-               close FILE;
-               if (open(FILE, "/proc/${pid}/status"))
-                       {
-                       while (<FILE>)
-                               {
-                               if (/^Name:\W+(.*)/)
-                                       {
-                                       $testcmd = $1;
-                                       }
-                               }
-                       close FILE;
-                       if ($testcmd =~ /$exename/)
-                               {
-                               $status = "<td align='center' bgcolor='${Header::colourgreen}'><font color='white'><b>$Lang::tr{'running'}</b></font></td>";
-                               }
-                       }
-               }
-       return $status;
-       }
-
 sub writeconfiguration() {
        open (FILE, ">${General::swroot}/samba/global") or die "Can't save the global settings: $!";
        flock (FILE, 2);