]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_repair: fix messaging when fixing imap due to sparse cluster
authorDarrick J. Wong <djwong@kernel.org>
Mon, 5 Jun 2023 15:38:01 +0000 (08:38 -0700)
committerCarlos Maiolino <cem@kernel.org>
Wed, 12 Jul 2023 07:15:18 +0000 (09:15 +0200)
This logic is wrong -- if we're in verbose dry-run mode, we do NOT want
to say that we're correcting the imap.  Otherwise, we print things like:

imap claims inode XXX is present, but inode cluster is sparse,

But then we can erroneously tell the user that we would correct the
imap when in fact we /are/ correcting it.

Fixes: f4ff8086586 ("xfs_repair: don't crash on partially sparse inode clusters")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
repair/dino_chunks.c

index 0841e65b184493d4a7935d31e7375ced51af7cc6..64ce2a323c8dfa222db67904ea5655a1a5e06beb 100644 (file)
@@ -834,7 +834,7 @@ next_readbuf:
                        do_warn(
        _("imap claims inode %" PRIu64 " is present, but inode cluster is sparse, "),
                                                ino);
-                       if (verbose || !no_modify)
+                       if (!no_modify)
                                do_warn(_("correcting imap\n"));
                        else
                                do_warn(_("would correct imap\n"));